proto: update the bitstring dep #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/py-bitstr
branch
2 times, most recently
from
65ccbcf to
8e6b792
Compare
cdecker
reviewed
Aug 26, 2023
| @@ -1,4 +1,4 @@ | |||
| import bitstring # type: ignore | |||
There was a problem hiding this comment.
Does bitstring now come with type annotations?
There was a problem hiding this comment.
i am using it here https://github.com/lnbits/bolt11 and neither mypy, pyright nor ruff are complaining :).
There was a problem hiding this comment.
i had type ignores all over the place in bolt11 before i updated to ^4
There was a problem hiding this comment.
From the bitsting release notes: Type hints added throughout the code. for v4.0.1
vincenzopalazzo
force-pushed
the
macros/py-bitstr
branch
from
8e6b792 to
eced836
Compare
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
nepet
force-pushed
the
macros/py-bitstr
branch
from
eced836 to
073584e
Compare
|
Rebased |
|
ACK 073584e |
|
Thanks @nepet I forgot about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative version to [1] that
update only the necessary information around our codebase to upgrade the bitstring package.
This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version.
[1] #6585